Adding New Lion:Bit STEM Board #8569

PradeepKotu · 2023-08-26T00:58:16Z

Description of Change

LionBit.cc introduces their latest development: the LionBit S3 STEM board, built around the powerful ESP32-S3. We kindly request the addition of this board to the official list of supported boards

Tests scenarios

Tested and already in the market

Related links

www.lionbit.cc

Added New LionBit Board Details

PradeepKotu · 2023-08-26T01:04:12Z

@atanisoft @P-R-O-C-H-Y please check

P-R-O-C-H-Y

@PradeepKotu Please take a look on my comments.

P-R-O-C-H-Y · 2023-08-28T11:22:02Z

boards.txt

+lionbits3.menu.JTAGAdapter.default=Disabled
+lionbits3.menu.JTAGAdapter.default.build.copy_jtag_files=0
+lionbits3.menu.JTAGAdapter.builtin=Integrated USB JTAG
+lionbits3.menu.JTAGAdapter.builtin.build.openocdscript=lionbits3-builtin.cfg
+lionbits3.menu.JTAGAdapter.builtin.build.copy_jtag_files=1
+lionbits3.menu.JTAGAdapter.external=FTDI Adapter
+lionbits3.menu.JTAGAdapter.external.build.openocdscript=lionbits3-ftdi.cfg
+lionbits3.menu.JTAGAdapter.external.build.copy_jtag_files=1
+lionbits3.menu.JTAGAdapter.bridge=ESP USB Bridge
+lionbits3.menu.JTAGAdapter.bridge.build.openocdscript=lionbits3-bridge.cfg
+lionbits3.menu.JTAGAdapter.bridge.build.copy_jtag_files=1


This won't work as you don't provide new configs. You need to leave the original JTAG configs from ESP32S3 Dev board.

Suggested change

lionbits3.menu.JTAGAdapter.default=Disabled

lionbits3.menu.JTAGAdapter.default.build.copy_jtag_files=0

lionbits3.menu.JTAGAdapter.builtin=Integrated USB JTAG

lionbits3.menu.JTAGAdapter.builtin.build.openocdscript=lionbits3-builtin.cfg

lionbits3.menu.JTAGAdapter.builtin.build.copy_jtag_files=1

lionbits3.menu.JTAGAdapter.external=FTDI Adapter

lionbits3.menu.JTAGAdapter.external.build.openocdscript=lionbits3-ftdi.cfg

lionbits3.menu.JTAGAdapter.external.build.copy_jtag_files=1

lionbits3.menu.JTAGAdapter.bridge=ESP USB Bridge

lionbits3.menu.JTAGAdapter.bridge.build.openocdscript=lionbits3-bridge.cfg

lionbits3.menu.JTAGAdapter.bridge.build.copy_jtag_files=1

lionbits3.menu.JTAGAdapter.default=Disabled

lionbits3.menu.JTAGAdapter.default.build.copy_jtag_files=0

lionbits3.menu.JTAGAdapter.builtin=Integrated USB JTAG

lionbits3.menu.JTAGAdapter.builtin.build.openocdscript=esp32s3-builtin.cfg

lionbits3.menu.JTAGAdapter.builtin.build.copy_jtag_files=1

lionbits3.menu.JTAGAdapter.external=FTDI Adapter

lionbits3.menu.JTAGAdapter.external.build.openocdscript=esp32s3-ftdi.cfg

lionbits3.menu.JTAGAdapter.external.build.copy_jtag_files=1

lionbits3.menu.JTAGAdapter.bridge=ESP USB Bridge

lionbits3.menu.JTAGAdapter.bridge.build.openocdscript=esp32s3-bridge.cfg

lionbits3.menu.JTAGAdapter.bridge.build.copy_jtag_files=1

P-R-O-C-H-Y · 2023-08-28T11:23:56Z

variants/lionbits3/pins_arduino.h

+
+//-------------------------------------------------------------------
+
+
+


Remove this empty part.

Suggested change

//-------------------------------------------------------------------

//-------------------------------------------------------------------

P-R-O-C-H-Y · 2023-08-28T11:27:53Z

variants/lionbits3/pins_arduino.h

+static const uint8_t U1RX = 9;  //I/O  U1RX     GPIO9
+static const uint8_t U1TX = 10; //I/O  U1TX     GPIO10
+/* LionBits3 pin setup */
+static const uint8_t D0 = 3;    //RX,           GPIO3,                      MCPWM,  U0RXD_in,U0CTS_in,U0DSR_in,U0TXD_out,UoRTS_out,U1RXD_in,U1CTS_in,U1DSR_in,U1TXD_out,U1RTS_out,U1DTR_out,U2RXD_in,U2CTS_in,U2DSR_in,U2TXD_out,U2RTS_out,U2DTR_out,LEDPWM


I don't get those comments about each pin, as most of the stuff is same for each pin.
For example all the U0xxx_xx ,U1xxx_xx, U2xxx_xx, MCPWM and LEDPWM. These can be on any pins so no need to comment it there.

Please remove those and just leave the good ones, as ADC pin, TOUCH

PradeepKotu

Updated as suggested @P-R-O-C-H-Y

variants/lionbits3/pins_arduino.h

P-R-O-C-H-Y · 2023-08-29T10:17:29Z

@PradeepKotu please take a look on @atanisoft review and fix it :).
One more question, as the the board.txt all options regarding FLASH, PSRAM are left and available, will the board be on market with different options on those? If not, the options which won't exist with the board should be removed.

As you suggested

variants/lionbits3/pins_arduino.h

P-R-O-C-H-Y · 2023-08-29T13:00:33Z

@PradeepKotu Any comments about my last question about Flash and PSRAM?

PradeepKotu · 2023-08-29T13:07:46Z

Dear Jan We print small quantities. Sometimes supplier sends us different versions. so no need to change it

…

On Tue, Aug 29, 2023 at 6:30 PM Jan Procházka ***@***.***> wrote: @PradeepKotu <https://github.com/PradeepKotu> Any comments about my last question about Flash and PSRAM? — Reply to this email directly, view it on GitHub <#8569 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIUD2IAY2Q7ULBZNYUMJ6F3XXXRXZANCNFSM6AAAAAA37FOBQQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Best Regards,* <https://mvp.support.microsoft.com/profile=F588DC6D-BCA6-43D9-A903-6F5FC88F5C29>*Awarded Winning Author* *Pradeep Kavinda Kotuwegedara **- (Justice of Peace - Whole Island)* (BSc (Hons) in IT, MCT, MCSD, MCSA, MCSE, ACA,Office Master, MVP Office System/Office 365) www.Kotuwegedara.com www.TuitionPanthiya.lk 077-2348985 , 077-4747119

PradeepKotu · 2023-08-29T13:11:19Z

@PradeepKotu Any comments about my last question about Flash and PSRAM?

Dear @P-R-O-C-H-Y
We print small quantities. Sometimes supplier sends us different versions.
so no need to change it

P-R-O-C-H-Y

Looks a lot cleaner now.
Btw. there is still comment about support of 5V. Can you explain @PradeepKotu what do you mean by that statement? Thanks

P-R-O-C-H-Y · 2023-08-29T14:14:02Z

@PradeepKotu please resolve the conflicts, so we can merge it :)

PradeepKotu · 2023-08-30T04:35:53Z

"This branch has conflicts that must be resolved, Only those with [write access] to this repository can merge pull requests." @P-R-O-C-H-Y Can you merge it for me?

P-R-O-C-H-Y · 2023-08-30T08:24:28Z

@PradeepKotu I cannot resolve the conflicts for you and I cannot merge now as the conflicts exists.
Please try to fix them.

PradeepKotu · 2023-08-30T09:17:39Z

@P-R-O-C-H-Y from my end i cant see any conflicts. every thing is fine. how i get to know is there any error?

P-R-O-C-H-Y · 2023-08-30T10:26:24Z

@P-R-O-C-H-Y from my end i cant see any conflicts. every thing is fine. how i get to know is there any error?

@PradeepKotu Do you see at the bottom of your PR where is the merge button this?

From my end I can see only the message: This branch has conflicts that must be resolved
You have to see more and even the Resolve Conflicts button.

VojtechBartoska · 2023-08-30T12:10:30Z

@PradeepKotu Will you be able to resolve those conflicts? We are also not able to modified your Pull Request, probably you will need to open a new Pull Request.

PradeepKotu · 2023-08-30T12:35:20Z

@VojtechBartoska I Fix the issue now we can merge I think .

P-R-O-C-H-Y

@PradeepKotu Conflicts resolved, but some leftovers are there. Please remove those.

boards.txt

P-R-O-C-H-Y

LGTM! Lets wait for CI to pass and then it will be merged ;)

Added New LionBit Board Details

3fbe1e3

Added New LionBit Board Details

P-R-O-C-H-Y self-assigned this Aug 28, 2023

P-R-O-C-H-Y requested changes Aug 28, 2023

View reviewed changes

P-R-O-C-H-Y added Type: 3rd party Boards Resolution: Awaiting response Waiting for response of author labels Aug 28, 2023

P-R-O-C-H-Y added this to the 2.0.12 milestone Aug 28, 2023

Updated

2a972b1

PradeepKotu commented Aug 28, 2023

View reviewed changes

atanisoft reviewed Aug 28, 2023

View reviewed changes

PradeepKotu added 2 commits August 29, 2023 17:46

Updated

64d00d8

As you suggested

Updated

19a4729

Pin

PradeepKotu commented Aug 29, 2023

View reviewed changes

variants/lionbits3/pins_arduino.h Show resolved Hide resolved

P-R-O-C-H-Y approved these changes Aug 29, 2023

View reviewed changes

atanisoft approved these changes Aug 29, 2023

View reviewed changes

P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Aug 29, 2023

VojtechBartoska added the Resolution: Awaiting response Waiting for response of author label Aug 30, 2023

wapradeepl force-pushed the master branch from 19a4729 to 057eac6 Compare August 30, 2023 12:13

Trying to resolve the confilict in boards.txt file

2ce5031

P-R-O-C-H-Y requested changes Aug 30, 2023

View reviewed changes

boards.txt Show resolved Hide resolved

boards.txt Show resolved Hide resolved

boards.txt Show resolved Hide resolved

removed the unwanted lines

25b86ce

P-R-O-C-H-Y approved these changes Aug 30, 2023

View reviewed changes

me-no-dev merged commit 8bfe3c4 into espressif:master Aug 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding New Lion:Bit STEM Board #8569

Adding New Lion:Bit STEM Board #8569

PradeepKotu commented Aug 26, 2023

PradeepKotu commented Aug 26, 2023

P-R-O-C-H-Y left a comment

P-R-O-C-H-Y Aug 28, 2023

P-R-O-C-H-Y Aug 28, 2023

P-R-O-C-H-Y Aug 28, 2023

PradeepKotu left a comment

P-R-O-C-H-Y commented Aug 29, 2023

P-R-O-C-H-Y commented Aug 29, 2023

PradeepKotu commented Aug 29, 2023 via email

PradeepKotu commented Aug 29, 2023

P-R-O-C-H-Y left a comment

P-R-O-C-H-Y commented Aug 29, 2023

PradeepKotu commented Aug 30, 2023

P-R-O-C-H-Y commented Aug 30, 2023

PradeepKotu commented Aug 30, 2023

P-R-O-C-H-Y commented Aug 30, 2023

VojtechBartoska commented Aug 30, 2023

PradeepKotu commented Aug 30, 2023

P-R-O-C-H-Y left a comment •

edited

Loading

P-R-O-C-H-Y left a comment •

edited

Loading


		//-------------------------------------------------------------------

Adding New Lion:Bit STEM Board #8569

Adding New Lion:Bit STEM Board #8569

Conversation

PradeepKotu commented Aug 26, 2023

Description of Change

Tests scenarios

Related links

PradeepKotu commented Aug 26, 2023

P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

P-R-O-C-H-Y Aug 28, 2023

Choose a reason for hiding this comment

P-R-O-C-H-Y Aug 28, 2023

Choose a reason for hiding this comment

P-R-O-C-H-Y Aug 28, 2023

Choose a reason for hiding this comment

PradeepKotu left a comment

Choose a reason for hiding this comment

P-R-O-C-H-Y commented Aug 29, 2023

P-R-O-C-H-Y commented Aug 29, 2023

PradeepKotu commented Aug 29, 2023 via email

PradeepKotu commented Aug 29, 2023

P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

P-R-O-C-H-Y commented Aug 29, 2023

PradeepKotu commented Aug 30, 2023

P-R-O-C-H-Y commented Aug 30, 2023

PradeepKotu commented Aug 30, 2023

P-R-O-C-H-Y commented Aug 30, 2023

VojtechBartoska commented Aug 30, 2023

PradeepKotu commented Aug 30, 2023

P-R-O-C-H-Y left a comment • edited Loading

Choose a reason for hiding this comment

P-R-O-C-H-Y left a comment • edited Loading

Choose a reason for hiding this comment

P-R-O-C-H-Y left a comment •

edited

Loading

P-R-O-C-H-Y left a comment •

edited

Loading